Open
Conversation
esoadamo
requested changes
Feb 28, 2025
Member
esoadamo
left a comment
esoadamo
left a comment
There was a problem hiding this comment.
Looks good, thanks! One, hopefully small, detail and LGTM.
Can you also please remove whitespace changes, so that the diff is not that big?
| this.basePath = basePath || configuration.basePath || this.basePath; | ||
| } | ||
|
|
||
| this.basePath = this.basePath.replace(/\/+$/, ''); // remove trailing slash |
Member
There was a problem hiding this comment.
Unfortunately it is impossible for us to modify this file since it is auto generated by npm run gen.api and as such these changes would be overwritten. Maybe this needs to be changed on backend instead?
Contributor
Author
sure, will work on it today :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backend fi-ksi/web-backend#227