Add middleware to remove trailing slash#320
Closed
keiranjprice101 wants to merge 16 commits intomainfrom
Closed
Conversation
keiranjprice101
force-pushed
the
add_root_path
branch
from
87a0ece to
472ada6
Compare
Collaborator
Author
|
Replaced |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to h5grove being updated. There was a breaking change which changed every single grove route to no longer include the trailing
/. However, the h5web components still expect this to exist.This adds a middleware to strip the trailing slash to allow the experiment viewers to still function in the meantime.
I have also added the filter to remove the health endpoints from the logging.