Conversation
pg-format's %L treats JS arrays as sub-tuples in multi-row VALUES,
producing 'TV' instead of '{TV}' for TEXT[] columns. This caused
'malformed array literal' errors during screentime recategorization
and productivity record insertion.
Add toPgArray() helper to properly serialize string arrays to
PostgreSQL array literal format, and apply it in both
batchUpdateResolvedCategory and insertProductivity.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #286 +/- ##
===========================================
+ Coverage 31.43% 31.88% +0.44%
===========================================
Files 181 181
Lines 22973 22992 +19
Branches 1855 1886 +31
===========================================
+ Hits 7222 7331 +109
+ Misses 15717 15627 -90
Partials 34 34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Covers insertProductivity, batchUpdateResolvedCategory, getAllProductivityForCategorization, deleteProductivityRecord, and restoreProductivityRecord with 21 tests including TEXT[] array round-trips through a real PostgreSQL instance.
…al-screentime-categories
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pg-format's%Ltreats JS arrays as sub-tuples in multi-row VALUES, producing'TV'instead of the required PostgreSQL array literal'{TV}'forTEXT[]columnstoPgArray()helper that properly serializesstring[]to PostgreSQL array literal format (with proper escaping of special characters)batchUpdateResolvedCategoryandinsertProductivitywhich had the same issue