fix #637: added test for fs.fsync()#638
Open
yatsenko-julia wants to merge 2 commits intofilerjs:masterfrom
Open
fix #637: added test for fs.fsync()#638yatsenko-julia wants to merge 2 commits intofilerjs:masterfrom
yatsenko-julia wants to merge 2 commits intofilerjs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #638 +/- ##
=======================================
Coverage 86.62% 86.62%
=======================================
Files 16 16
Lines 1742 1742
=======================================
Hits 1509 1509
Misses 233 233Continue to review full report at Codecov.
|
humphd
requested changes
Dec 20, 2018
Contributor
humphd
left a comment
humphd
left a comment
There was a problem hiding this comment.
The changes in fs.fsync.spec.js look good, but can you rebase to get rid of your extra changes in fs.ftruncate.spec.js, which I are from your other PR? I've merged that, so it should pick it up from master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.