Code Quality: Fixed HighContrast theme resources #17409
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaira2
reviewed
Aug 7, 2025
| @@ -5,6 +5,21 @@ | |||
| xmlns:animatedvisuals="using:Microsoft.UI.Xaml.Controls.AnimatedVisuals" | |||
| xmlns:local="using:Files.App.Controls"> | |||
|
|
|||
| <ResourceDictionary.ThemeDictionaries> | |||
| <ResourceDictionary x:Key="Default"> | |||
| <StaticResource x:Key="ButtonBackgroundPointerOver" ResourceKey="SubtleFillColorSecondaryBrush" /> | |||
There was a problem hiding this comment.
Overriding WinUI brushes across an entire XAML file introduces potential risks and unintended side effects. It would be safer to stick with our previous approach using lightweight styling and apply a custom brush if needed.
yaira2
reviewed
Aug 7, 2025
| @@ -180,13 +191,8 @@ | |||
| BorderBrush="{TemplateBinding BorderBrush}" | |||
| BorderThickness="{TemplateBinding BorderThickness}" | |||
| CornerRadius="{StaticResource BreadcrumbBarChevronCornerRaduis}" | |||
| Style="{StaticResource BreadcrumbBarItemChevronButtonStyle}" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Steps used to test these changes