Skip to content

Fixed all warnings which are fixable #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Fixed all warnings which are fixable #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71087eb
Fixed all warnings which are fixable
AtulCel Nov 14, 2024
b028789
change modifier open to public
AtulCel Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/FilestackSDK/Internal/Extensions/Data+base64MD5Digest.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ extension Data {
return Data((withUnsafeBytes { byte -> [UInt8] in
var digest = [UInt8](repeating: 0, count: Int(CC_MD5_DIGEST_LENGTH))

CC_MD5(byte.baseAddress, CC_LONG(count), &digest)
CC_SHA256(byte.baseAddress, CC_LONG(count), &digest)

return digest
})).base64EncodedString()
Expand Down
2 changes: 1 addition & 1 deletion Sources/FilestackSDK/Internal/Operations/CommitPartUploadOperation.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

import Foundation

class CommitPartUploadOperation: BaseOperation<HTTPURLResponse> {
class CommitPartUploadOperation: BaseOperation<HTTPURLResponse>, @unchecked Sendable {
// MARK: - Private Properties

private let descriptor: UploadDescriptor
Expand Down
2 changes: 1 addition & 1 deletion Sources/FilestackSDK/Internal/Operations/CompleteUploadOperation.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

import Foundation

class CompleteUploadOperation: BaseOperation<JSONResponse> {
class CompleteUploadOperation: BaseOperation<JSONResponse>, @unchecked Sendable {
// MARK: - Private Properties

private let partsAndEtags: [Int: String]
Expand Down
2 changes: 1 addition & 1 deletion Sources/FilestackSDK/Internal/Operations/StartUploadOperation.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

import Foundation

class StartUploadOperation: BaseOperation<UploadDescriptor> {
class StartUploadOperation: BaseOperation<UploadDescriptor>, @unchecked Sendable {
// MARK: - Private Properties

private let config: Config
Expand Down
2 changes: 1 addition & 1 deletion Sources/FilestackSDK/Internal/Operations/SubmitChunkUploadOperation.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

import Foundation

class SubmitChunkUploadOperation: BaseOperation<HTTPURLResponse> {
class SubmitChunkUploadOperation: BaseOperation<HTTPURLResponse>, @unchecked Sendable {
// MARK: - Internal Properties

// Part offset
Expand Down
2 changes: 1 addition & 1 deletion Sources/FilestackSDK/Internal/Operations/SubmitPartIntelligentUploadOperation.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

import Foundation

class SubmitPartIntelligentUploadOperation: BaseOperation<HTTPURLResponse>, SubmitPartUploadOperation {
class SubmitPartIntelligentUploadOperation: BaseOperation<HTTPURLResponse>, SubmitPartUploadOperation, @unchecked Sendable {
// MARK: - Internal Properties

let number: Int
Expand Down
2 changes: 1 addition & 1 deletion Sources/FilestackSDK/Internal/Operations/SubmitPartRegularUploadOperation.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

import Foundation

class SubmitPartRegularUploadOperation: BaseOperation<HTTPURLResponse>, SubmitPartUploadOperation {
class SubmitPartRegularUploadOperation: BaseOperation<HTTPURLResponse>, SubmitPartUploadOperation, @unchecked Sendable {
// MARK: - Internal Properties

let number: Int
Expand Down
2 changes: 1 addition & 1 deletion Sources/FilestackSDK/Internal/Operations/SubmitPartsUploadOperation.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

import Foundation

class SubmitPartsUploadOperation: BaseOperation<[Int: String]> {
class SubmitPartsUploadOperation: BaseOperation<[Int: String]>, @unchecked Sendable {
// MARK: - Internal Properties

let descriptor: UploadDescriptor
Expand Down
2 changes: 1 addition & 1 deletion Sources/FilestackSDK/Internal/Operations/UploadOperation.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

import Foundation

class UploadOperation: BaseOperation<JSONResponse> {
class UploadOperation: BaseOperation<JSONResponse>, @unchecked Sendable {
// MARK: - Internal Properties

private(set) lazy var progress: Progress = {
Expand Down
4 changes: 2 additions & 2 deletions Sources/FilestackSDK/Public/Operations/BaseOperation.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import Foundation
/// - An executing operation will return `isExecuting` true.
/// - A finished operation will return `isFinished` true.
/// - A cancelled operation will return `isCancelled` true.
open class BaseOperation<Success>: Operation {
open class BaseOperation<Success>: Operation, @unchecked Sendable {
public typealias Result = Swift.Result<Success, Error>

// MARK: - Private Properties
Expand Down Expand Up @@ -81,7 +81,7 @@ open class BaseOperation<Success>: Operation {

extension BaseOperation {
/// Returns the result of operation.
open private(set) var result: Result {
public private(set) var result: Result {
get { lockQueue.sync { _result } }
set { lockQueue.sync { _result = newValue } }
}
Expand Down