implement software SPI (not tested), custom TwoWire instance (tested)#19
Open
wb1016 wants to merge 1 commit intofinani:masterfrom
Open
implement software SPI (not tested), custom TwoWire instance (tested)#19wb1016 wants to merge 1 commit intofinani:masterfrom
wb1016 wants to merge 1 commit intofinani:masterfrom
Conversation
Owner
|
Thank you for your contribution! The default target board is Arduino, so please add comments like this. I checked a few points do not follow formats such as whitespace in the parenthesis, but don't mind about formats. Everything else looks great! One thing I worried about is I have no test device now. |
Author
|
i only have my test device in I2C interface. i'll ask someone to test my code instead. |
Owner
|
Awesome! Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
by using Adafruit's LSM6DS and BusIO library as reference, i have implemented software SPI and ability to accept custom TwoWire instance. this is quite necessary for various ESP32 boards since they dont use predefined pins for communication.
this is my first cpp work. code review is welcomed.