A function to clear all previously added objects to the GameArena.#10
Open
ykolarov wants to merge 1 commit intofinneyj:masterfrom
Open
A function to clear all previously added objects to the GameArena.#10ykolarov wants to merge 1 commit intofinneyj:masterfrom
ykolarov wants to merge 1 commit intofinneyj:masterfrom
Conversation
finneyj
reviewed
May 5, 2020
| * should appear on the GameArena window after this has executed. | ||
| */ | ||
| public void clearGameArena() { | ||
| things.clear(); |
Owner
There was a problem hiding this comment.
Looks good!
I think we should protect this code with a synchronized block though. This would prevent the list of objects being cleared during the time that the list is iterated over by the draw() method. I suspect we would get a crash if the user cleared the list during this time.
Could you add a synchronized block around this line, like we do when adding an object:
https://github.com/finneyj/GameArena/blob/master/GameArena.java#L311
If you can add that, and quickly test that it works OK on your code, I'll happily merge this in. :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since GameArena is already keeping track of what is added to it, it makes sense it should be able to remove everything with one function.
This implementation has been poorly tested, with only 2 different programs, but worked as expected for both them.