Skip to content

Fix bug when reloading page with parameters in URL #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SteffeyDev wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix bug when reloading page with parameters in URL #229

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e53c8fd
Fix bug when reloading page with parameters in URL
SteffeyDev Dec 9, 2019
c52188d
Fix to account for undefined parent.route[0]
SteffeyDev Dec 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -815,7 +815,7 @@
if (urlToggle !== 'none') {
// check if this page should trigger showChild at parent
var parent = m.parentPage;
if (parent.route && (parent.route[0] === m.getId() || (parent.route.length && m.getId() === '?') )) {
if (parent.route && parent.route.length && (parent.route[0].split('?')[0] === m.getId() || m.getId() === '?')) {
// call once the current event loop is finished.
setTimeout(function () {
parent.showPage(parent.route);
Expand Down