Conversation
✅ Deploy Preview for fdc3 canceled.
|
|
|
|
|
2 similar comments
|
|
|
|
psmulovics
approved these changes
Apr 10, 2025
kriswest
requested changes
Apr 10, 2025
|
|
||
| ### Added | ||
|
|
||
| * Add a notes field to trade, order and product types ([#1563](https://github.com/finos/FDC3/pull/1563)) |
Contributor
There was a problem hiding this comment.
The PR in question only added the notes field to the trade type.
Another open PR #1503 goes further and adds notes to Order and Product. It also created the RFQ type and was trying to define Product properly (which we probably won't merge).
Contributor
|
closed in favour of #1597 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changlog for
#1373