Conversation
✅ Deploy Preview for fdc3 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
|
|
|
Just had a play with this on sail.fdc3.finos.org - looks mainly good although I get this error for app channels: 
|
|
closing to reopen (as that may trigger the CVE scan again) |
|
|
|
|
1 similar comment
|
|
I don't get that in the reference implementation - working fine for me... is it a sail issue? However the intent name selector under raiseIntent and addIntentListener are not working for me. That's the only flaw I see so far |
| }, | ||
| ]; | ||
| const fdc3Server = new DefaultFDC3Server(sc, directory, channelDetails, true, 20000, 10017); | ||
| const fdc3Server = new DefaultFDC3Server(sc, directory, channelDetails, true, 20000, 15000); |
There was a problem hiding this comment.
made the heartbeats less annoying as they were getting in the way when testing
| <select name="opener" id="opener"> | ||
| <option value="Tab" default>New Tab</option> | ||
| <option value="Frame">Frame</option> | ||
| <option value="Frame" default>Frame</option> |
There was a problem hiding this comment.
Changed default to open an iframe as it makes testing less annoying
kriswest
left a comment
kriswest
left a comment
There was a problem hiding this comment.
I pushed fixes for the only issues I saw - then fixed the linting and caught a few minor issues - working very nicely for me in the web demo - I say merge it.
However, I have last push so someone else will ahve to approve and merge. That can be done before the 2.2.2 release - someone hit the button!
@finos/fdc3-maintainers
|
@Roaders can you resolve conflicts and rebase on main then we can merge this |
|
I have rebased and now I'm getting failing tests in fdc3-web-impl. Also tests seem to not exit... |
|
|
|
ok, I managed to get the tests working but I really have no understanding of what the issue was and not much confidence in the fix. It seems to be to do with heartbeats in the web-impl package. Our AI overlords also added an @kriswest - perhaps you could take a look at this and make sure you are happy with the fixes? |
|
PR link added to changelog |
|
|
|
updated axios to fix CVE scanning. Website still appears to work without issue |
|
|
3 participants
Describe your change
Migrate Workbench to MUI 5
I got access to a new AI agent and as Kris has often asked someone to have a go at this I gave it a try. From my tests workbench still works fine and looks the same as it did before so I don't think anything has been broken. I have by no means tested every single element in the workbench though.
Contributor License Agreement
Review Checklist
DesktopAgent,Channel,PrivateChannel,Listener,Bridging)?JSDoc comments on interfaces and types should be matched to the main documentation in /docs
Conformance test definitions should cover all required aspects of an FDC3 Desktop Agent implementation, which are usually marked with a MUST keyword, and optional features (SHOULD or MAY) where the format of those features is defined
The Web Connection protocol and Desktop Agent Communication Protocol schemas must be able to support all necessary aspects of the Desktop Agent API, while Bridging must support those aspects necessary for Desktop Agents to communicate with each other
npm run build) run and the results checked in?Generated code will be found at
/src/api/BrowserTypes.tsand/or/src/bridging/BridgingTypes.tsBaseContextschema applied viaallOf(as it is in existing types)?titleanddescriptionprovided for all properties defined in the schema?npm run build) run and the results checked in?Generated code will be found at
/src/context/ContextTypes.tsTHIS SOFTWARE IS CONTRIBUTED SUBJECT TO THE TERMS OF THE FINOS CORPORATE CONTRIBUTOR LICENSE AGREEMENT.
THIS SOFTWARE IS LICENSED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE AND ANY WARRANTY OF NON-INFRINGEMENT, ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. THIS SOFTWARE MAY BE REDISTRIBUTED TO OTHERS ONLY BY EFFECTIVELY USING THIS OR ANOTHER EQUIVALENT DISCLAIMER IN ADDITION TO ANY OTHER REQUIRED LICENSE TERMS.