test: convert AppDirectory test to Jest and run in CI#1720
test: convert AppDirectory test to Jest and run in CI#1720adityashirsatrao007 wants to merge 5 commits intofinos:mainfrom
Conversation
✅ Deploy Preview for fdc3 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR successfully migrates the standalone App Directory specification tests into the main Jest test suite, enabling automated validation in CI. The migration converts a node.js script-based test into a proper Jest test suite that validates the App Directory OpenAPI schema and example application files.
- Adds a new Jest test file that validates the App Directory schema and example files
- Moves test dependencies from a standalone package to the main package's devDependencies
- Removes the legacy standalone test directory and its configuration files
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/fdc3-standard/test/AppDirectory.test.ts | New Jest test suite that validates the App Directory OpenAPI schema and example application JSON files (myApplication.json and fdc3-workbench.json) |
| packages/fdc3-standard/package.json | Adds @apidevtools/swagger-parser and jsonschema as devDependencies for schema validation |
| packages/fdc3-standard/src/app-directory/specification/test/package.json | Removes standalone test package.json that is no longer needed |
| packages/fdc3-standard/src/app-directory/specification/test/package-lock.json | Removes standalone test package-lock.json that is no longer needed |
| packages/fdc3-standard/src/app-directory/specification/test/index.js | Removes legacy node.js test script replaced by the new Jest test |
Files not reviewed (1)
- packages/fdc3-standard/src/app-directory/specification/test/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@copilot open a new pull request to apply changes based on the comments in this thread |
kriswest
left a comment
There was a problem hiding this comment.
Thanks for this - revealed a small bug in the appD schema.
kriswest
left a comment
There was a problem hiding this comment.
Oops - forgot to check for a CHANEGELOG.md entry. Could you add one to the Unreleased -> CHANGED section of CHANGELOG.md. I suggest:
Converted the standalone app-directory specification test from "src/app-directory/specification/test/" into a proper Jest test that runs as part of CI. ([#1720](https://github.com/finos/FDC3/pull/1720))
|
If you |
|
@adityashirsatrao007 could you:
|
Converts the standalone app-directory specification test into a proper Jest test that runs as part of CI. Changes: - Added test/AppDirectory.test.ts with tests for: - Valid API name and version - myApplication.json example validation - fdc3-workbench.json example validation - Added @apidevtools/swagger-parser and jsonschema to devDependencies - Removed src/app-directory/specification/test/ directory Closes finos#1716
b428aa1 to
4a29b4e
Compare
|
@adityashirsatrao007 the CI tasks is still failing as there are some items missing from the package-lock.json file for the new dependencies you added. Could you run |
Summary
Converts the standalone app-directory specification test from \src/app-directory/specification/test/\ into a proper Jest test that runs as part of CI.
Changes
Testing
Run the tests:
\\�ash
npm run test --workspace=@finos/fdc3-standard
\\
Closes #1716