Skip to content

250: adding a temporary change in reminderController #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: spring-bot-master
Choose a base branch
from
Open

250: adding a temporary change in reminderController #459

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions tools/reminder-bot/src/main/java/org/finos/springbot/tool/reminders/ReminderController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,25 +36,34 @@ public class ReminderController {

@ChatButton(buttonText = "Add", value = Reminder.class, showWhen = WorkMode.EDIT)
public ReminderList addreminder(Reminder cr, Addressable a, User author) {
ReminderList rl = list(a);
rl.reminders.add(cr);
return rl;
if (cr.getLocalTime().isBefore(LocalDateTime.now())) {

}
// You can throw an exception or return an error response

throw new IllegalArgumentException("Reminder time must be in the future.");
}

ReminderList rl = list(a);
rl.reminders.add(cr);
return rl;
}

@ChatRequest(value = "list", description = "Show list of Reminders")
@ChatResponseBody(workMode = WorkMode.VIEW)
public ReminderList list(Addressable a) {
Optional<ReminderList> rl = h.getLastFromHistory(ReminderList.class, a);

if (rl.isPresent()) {
// Filter out past reminders
rl.get().getReminders().removeIf(r -> r.getLocalTime().isBefore(LocalDateTime.now()));
return rl.get();
} else {
ReminderList out = new ReminderList();
out.setTimeZone(rp.getDefaultTimeZone());
out.setRemindBefore(rp.getDefaultRemindBefore());
return out;
}

}

@ChatButton(buttonText = "save", value = ReminderList.class, showWhen = WorkMode.EDIT)
Expand Down