Skip to content

feat(auth): Firebase Auth add link domain to actionCodeSetting #1115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat(auth): Firebase Auth add link domain to actionCodeSetting #1115

wants to merge 4 commits into from

Conversation

Xiaoshouzi-gh
Copy link

@Xiaoshouzi-gh Xiaoshouzi-gh commented Jul 15, 2025 •
edited by jonathanedey
Loading

  • Add linkDomain to ActionCodeSettings, this allows developers to pass in customized Firebase Hosting Domains for applinks to open in mobile apps.
  • Added error code.

Edit: This PR also deprecates dynamicLinkDomain

@jonathanedey jonathanedey added the release:stage Stage a release candidate label Aug 8, 2025
@lahirumaramba lahirumaramba changed the title Firebase Auth add link domain to actionCodeSetting feat(auth): Firebase Auth add link domain to actionCodeSetting Aug 12, 2025
@lahirumaramba lahirumaramba self-requested a review August 12, 2025 15:34
@lahirumaramba lahirumaramba self-assigned this Aug 12, 2025
lahirumaramba
lahirumaramba approved these changes Aug 12, 2025
View reviewed changes
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's get a TW review on the docs. Thanks!

@jonathanedey jonathanedey requested a review from egilmorez August 12, 2025 16:12
egilmorez
egilmorez approved these changes Aug 13, 2025
View reviewed changes
Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG with a literal nit, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahirumaramba lahirumaramba lahirumaramba approved these changes

@egilmorez egilmorez egilmorez approved these changes

Assignees

@lahirumaramba lahirumaramba

@pashanka pashanka

Labels
release:stage Stage a release candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Xiaoshouzi-gh @lahirumaramba @egilmorez @jonathanedey @pashanka