[Firebase AI] Rename module to FirebaseAILogic
#15275
Draft
+487
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # FirebaseAI/Tests/TestApp/Tests/Integration/GenerateContentIntegrationTests.swift
# Conflicts: # FirebaseAI.podspec
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the FirebaseAI module by renaming it to FirebaseAILogic and introducing a new FirebaseAI wrapper module that re-exports FirebaseAILogic. This is a good structural change that aligns with patterns in other Firebase SDKs. The changes are mostly mechanical renaming across many files. I've found a couple of areas for improvement in the podspec and Swift Package Manager configuration to enhance maintainability and correctness. Overall, the changes look good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP - testing module rename with quickstart
#no-changelog