Fix format errors

Firestore/core/src/api/expressions.h

@@ -43,7 +43,7 @@ class Expr {
 
 class Selectable : public Expr {
  public:
-  virtual ~Selectable() override = default;
+  ~Selectable() override = default;
   virtual const std::string& alias() const = 0;
 };
 

Firestore/core/src/api/pipeline_result.h

@@ -51,7 +51,7 @@ class PipelineResult {
 
   PipelineResult() = default;
 
-  PipelineResult(model::Document document)
+  explicit PipelineResult(model::Document document)
       : internal_key_{document->key()},
         value_{document->shared_data()},
         // TODO(pipeline): add create time support

Firestore/core/src/api/query_snapshot.cc

@@ -17,6 +17,7 @@
 #include "Firestore/core/src/api/query_snapshot.h"
 
 #include <utility>
+#include <vector>
 
 #include "Firestore/core/src/api/document_change.h"
 #include "Firestore/core/src/api/document_snapshot.h"

Firestore/core/src/api/query_snapshot.h

@@ -20,6 +20,7 @@
 #include <functional>
 #include <memory>
 #include <utility>
+#include <vector>
 
 #include "Firestore/core/src/api/api_fwd.h"
 #include "Firestore/core/src/api/document_change.h"

Firestore/core/src/api/realtime_pipeline_snapshot.h

@@ -68,4 +68,4 @@ class RealtimePipelineSnapshot {
 }  // namespace firestore
 }  // namespace firebase
 
-#endif  // FIRESTORE_CORE_SRC_API_REAL_TIME_PIPELINE_SNAPSHOT_H_
+#endif  // FIRESTORE_CORE_SRC_API_REALTIME_PIPELINE_SNAPSHOT_H_

Firestore/core/src/core/expressions_eval.cc

@@ -447,6 +447,7 @@ EvaluateResult CoreEq::CompareToResult(const EvaluateResult& left,
     case model::StrictEqualsResult::kNull:
       return EvaluateResult::NewNull();
   }
+  HARD_FAIL("Unhandled case in switch statement");
 }
 
 EvaluateResult CoreNeq::CompareToResult(const EvaluateResult& left,
@@ -469,6 +470,7 @@ EvaluateResult CoreNeq::CompareToResult(const EvaluateResult& left,
     case model::StrictEqualsResult::kNull:
       return EvaluateResult::NewNull();
   }
+  HARD_FAIL("Unhandled case in switch statement");
 }
 
 EvaluateResult CoreLt::CompareToResult(const EvaluateResult& left,
@@ -584,8 +586,8 @@ template <typename T>
 bool ProcessUtf8(const std::string& s,
                  T* result,
                  std::function<void(T*, uint32_t, absl::string_view)> func) {
-  int i = 0;
-  const int len = s.size();
+  size_t i = 0;
+  const size_t len = s.size();
   const unsigned char* data = reinterpret_cast<const unsigned char*>(s.data());
 
   while (i < len) {
@@ -988,10 +990,9 @@ EvaluateResult CoreTrim::Evaluate(
 
   switch (evaluated.type()) {
     case EvaluateResult::ResultType::kString: {
-      absl::string_view trimmed_view = absl::StripAsciiWhitespace(
-          nanopb::MakeString(evaluated.value()->string_value));
-      return EvaluateResult::NewValue(
-          model::StringValue(std::move(trimmed_view)));
+      std::string str = nanopb::MakeString(evaluated.value()->string_value);
+      absl::string_view trimmed_view = absl::StripAsciiWhitespace(str);
+      return EvaluateResult::NewValue(model::StringValue(trimmed_view));
     }
     case EvaluateResult::ResultType::kNull:
       return EvaluateResult::NewNull();

Firestore/core/src/core/view.cc

@@ -20,10 +20,10 @@
 #include <utility>
 #include <valarray>
 
+#include "Firestore/core/src/core/pipeline_run.h"
 #include "Firestore/core/src/core/target.h"
 #include "Firestore/core/src/model/document_set.h"
 #include "Firestore/core/src/util/hard_assert.h"  // For HARD_ASSERT and HARD_FAIL
-#include "pipeline_run.h"
 
 namespace firebase {
 namespace firestore {