Fix the __name__ normalization for vector index
#9407
Merged
+342
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Vector index of standard edition database are not properly handled when it comes to
__name__normalization, which can cause issues like #9385. This PR is to address that issue.Scenarios Tested
A reproduce of #9385 -
firestore.indexes.jsonwithfirebase deploy --only firestore:indexesand successfully deploy the indexfirebase firestore:indexes --database=index-fix > firestore.indexes.jsonand confirm the normalization is properly handled.firebase deploy --only firestore:indexesand no error shows up.See the test added to
src/firestore/indexes.spec.tsfor other scenarios tested.