-
Notifications
You must be signed in to change notification settings - Fork 46
[Dynamic Links] Remove the Dynamic Links library #1281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @a-maurice, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily focuses on removing the deprecated Firebase Dynamic Links library and cleaning up residual components of the Firebase Invites library from the SDK. Concurrently, it updates various system configurations and documentation to acknowledge the new 'Firebase AI Logic' component, streamlining the codebase and ensuring accurate representation of supported features.
Highlights
- Removal of Deprecated Libraries: The Firebase Dynamic Links library has been completely removed from the SDK, including its build configurations, documentation, editor integration, and test app references. Additionally, lingering references to the deprecated Firebase Invites library have been cleaned up across various files.
- Integration of Firebase AI Logic: References to 'Firebase AI Logic' have been added to issue templates and the main
README.md
anddocs/readme.md
files, indicating its inclusion or preparation for integration within the SDK's supported features. - Build System and Documentation Updates: The build system (CMake, Python scripts) and various documentation files (READMEs, issue templates) have been updated to reflect the removal of Dynamic Links and Invites, and the addition of Firebase AI Logic.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively removes the deprecated Dynamic Links library and lingering references to the Invites library. The changes are comprehensive, touching build configurations, source code, documentation, and CI scripts. The addition of "Firebase AI Logic" to documentation and issue templates is also correctly implemented. The code removals are clean and I couldn't find any remaining artifacts of the deprecated libraries. The project cleanup, like updating test app settings, is a nice touch. Overall, this is a solid and well-executed change.
Description
Remove the deprecated Dynamic Links library. Also, removed some lingering parts of Invites, and added AI Logic to a couple of the files it was missing from.
Testing
https://github.com/firebase/firebase-unity-sdk/actions/runs/16012750084
Type of Change
Place an
x
the applicable box: