Skip to content

[Firebase AI] Add the test json files #1282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 3, 2025
Merged

[Firebase AI] Add the test json files #1282

merged 3 commits into from
Jul 3, 2025

Conversation

a-maurice
Copy link
Collaborator

Description

Provide details of the change, and generalize the change in the PR title above.

Add the Firebase AI test json files, to reduce the need to download it each time.


Testing

Describe how you've tested these changes.

Running locally


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @a-maurice, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Firebase AI test application by integrating local JSON test data, thereby minimizing external dependencies and accelerating test execution. It also expands the test coverage to include new image generation functionalities, ensuring robust validation of these features.

Highlights

  • Improved Test Efficiency: I've updated the test application to first attempt loading mock JSON test data from local StreamingAssets before falling back to downloading it from a GitHub repository. This change aims to significantly reduce the need for repeated network downloads during local testing, making the test suite faster and more reliable.
  • Expanded Image Generation Tests: I've introduced new test methods specifically for the Firebase AI ImagenModel, covering various image generation scenarios. These include tests for successful image generation, handling of all-filtered and partially-filtered image responses, and verification of image properties like MIME type and dimensions.
  • New Local Test Data Files: A comprehensive set of new JSON files has been added to the Assets/StreamingAssets/TestData directory. These files contain mock API responses for both Google AI and Vertex AI backends, including various success and failure cases, image generation results, and citation metadata, supporting the new local data loading mechanism.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds local JSON files for testing to avoid downloading them on each run. The changes primarily involve updating the test handler UIHandlerAutomated.cs to load these local files and adding new tests for the Imagen model. The overall changes look good, but I have a couple of suggestions to improve resource management and test maintainability.

@a-maurice a-maurice requested a review from cynthiajoan July 3, 2025 00:19
@a-maurice a-maurice merged commit 1172af2 into main Jul 3, 2025
15 of 17 checks passed
@a-maurice a-maurice deleted the am-json_files branch July 3, 2025 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants