feat(firebaseai): server template #17767
Conversation
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for server-side templates in Firebase AI, including new model classes (TemplateGenerativeModel, TemplateImagenModel), API abstractions for template URIs, and a new example page to demonstrate the feature. The core logic seems well-structured and is accompanied by tests. My review includes a few points: a critical fix to remove a debug print statement, a high-severity bug fix in the new example page where user input was being ignored, and a low-severity suggestion to refactor some redundant code for better maintainability.
| Future<void> _sendServerTemplateMessage(String message) async { | ||
| setState(() { | ||
| _loading = true; | ||
| }); | ||
|
|
||
| try { | ||
| var response = await _templateGenerativeModel | ||
| ?.generateContent('new-greeting', inputs: {}); | ||
|
|
||
| _messages.add(MessageData(text: response?.text, fromUser: false)); | ||
|
|
||
| setState(() { | ||
| _loading = false; | ||
| _scrollDown(); | ||
| }); | ||
| } catch (e) { | ||
| _showError(e.toString()); | ||
| setState(() { | ||
| _loading = false; | ||
| }); | ||
| } finally { | ||
| _textController.clear(); | ||
| setState(() { | ||
| _loading = false; | ||
| }); | ||
| _textFieldFocus.requestFocus(); | ||
| } | ||
| } |
There was a problem hiding this comment.
This method has a couple of issues that affect user experience and correctness:
- User message not displayed: The user's input
messageis not added to the_messageslist, so it doesn't appear in the chat UI after being sent. - Unused input: The
messageparameter is not used in thegenerateContentcall. Theinputsmap is empty, so the model's response won't be based on what the user typed.
You should add the user's message to the UI and pass it to the model via the inputs map.
| Future<Map<String, Object?>> makeRequest( | ||
| Uri uri, Map<String, Object?> body) async { | ||
| final headers = await _headers(); | ||
| print('uri: $uri \nbody: $body \nheaders: $headers'); |
There was a problem hiding this comment.
This print statement appears to be for debugging. It should be removed to avoid logging sensitive information and polluting production logs.
| setState(() { | ||
| _loading = false; | ||
| }); |
There was a problem hiding this comment.
This setState call to set _loading = false is redundant, as _loading is already being set to false within the try block (line 200) and the catch block (line 206). To simplify, you could handle setting _loading = false in a single place, for example, only in the finally block, and remove the corresponding setState calls from try and catch.
1 participant
Description
Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.
Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?