-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[FirebaseAI] Add Live Audio screen #1776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @daymxn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates a new 'Live Audio' feature into the Firebase AI example application. It provides a practical demonstration of how to leverage the Live API for interactive audio experiences with a Gemini model, encompassing real-time transcription, dynamic UI updates via function calls, and sophisticated audio management for various device configurations. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a LiveAudioScreen
to the AI sample app, demonstrating audio-to-audio communication with a Gemini model. The implementation is comprehensive, covering audio capture, playback, transcription, and function calling. The code is well-structured, particularly the audio handling logic in AudioController
and the typewriter effect for transcripts in TranscriptViewModel
. My review focuses on enhancing the robustness and thread safety of the new features. I've provided suggestions to replace fatalError
calls with more graceful error handling to prevent application crashes and to convert the AudioController
class to an actor
to prevent potential race conditions. These changes will improve the stability of the sample app and make it a better reference for production-level code.
This adds the
LiveAudioScreen
to the AI sample app. Since the Live API was released with12.4.0
, this adds a sample app showcasing how you can do audio to audio communication with a Gemini model.The new screen also supports the following: