-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: Replace storyboard Performance QS with SwiftUI one #1827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @ncooke3, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modernizes the Firebase Performance Monitoring Quickstart by migrating it from a Storyboard-based architecture to a SwiftUI-based one. The changes encompass a complete restructuring of the project, updating build configurations, and refreshing documentation to provide a contemporary example for developers using Firebase Performance Monitoring with SwiftUI. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully replaces the dated, Storyboard-driven Performance Quickstart with a modern SwiftUI implementation. The changes primarily involve restructuring the project, renaming and removing old files, and updating the Xcode project settings and dependencies accordingly. The README.md has also been significantly improved with clearer and more comprehensive setup instructions.
While the code in performance/Shared/Process.swift was only moved and not modified in this pull request, I identified a couple of areas for improvement. The classifyImage() and generateSaliencyMap() functions perform blocking operations on the main thread, which can lead to UI freezes. I recommend dispatching these tasks to a background queue (e.g., using DispatchQueue.global().async) to ensure a responsive user experience. Additionally, the categories property in the Process class should be marked with @Published to ensure the UI updates reliably when it changes. Since these files were only moved and not modified in this PR, I'm unable to leave inline comments, but I strongly suggest addressing these points in a follow-up PR to improve the app's performance and robustness.
We had a SwiftUI performance QS that I'm making the default Performance QS and removing the dated, Swift, storyboard-driven QS