Skip to content

Conversation

@ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Dec 11, 2025

We had a SwiftUI performance QS that I'm making the default Performance QS and removing the dated, Swift, storyboard-driven QS

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ncooke3, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modernizes the Firebase Performance Monitoring Quickstart by migrating it from a Storyboard-based architecture to a SwiftUI-based one. The changes encompass a complete restructuring of the project, updating build configurations, and refreshing documentation to provide a contemporary example for developers using Firebase Performance Monitoring with SwiftUI.

Highlights

  • Quickstart Migration: The existing Firebase Performance Monitoring Quickstart, previously based on Storyboards, has been fully replaced with a modern SwiftUI implementation.
  • Project Structure Overhaul: The entire project directory for the SwiftUI quickstart has been moved to the root performance/ directory, effectively making it the primary example. This involved numerous file renames and deletions of the old Storyboard-based files.
  • Xcode Project Updates: The Xcode project file (project.pbxproj) has been extensively modified to reflect the new SwiftUI app structure, including new targets for iOS and tvOS, updated build settings, and an upgrade of the firebase-ios-sdk dependency to version 12.0.0.
  • Documentation Refresh: The main README.md file has been updated with new setup instructions tailored for the SwiftUI quickstart, including important details about Cloud Storage security rules and troubleshooting package cache issues.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully replaces the dated, Storyboard-driven Performance Quickstart with a modern SwiftUI implementation. The changes primarily involve restructuring the project, renaming and removing old files, and updating the Xcode project settings and dependencies accordingly. The README.md has also been significantly improved with clearer and more comprehensive setup instructions.

While the code in performance/Shared/Process.swift was only moved and not modified in this pull request, I identified a couple of areas for improvement. The classifyImage() and generateSaliencyMap() functions perform blocking operations on the main thread, which can lead to UI freezes. I recommend dispatching these tasks to a background queue (e.g., using DispatchQueue.global().async) to ensure a responsive user experience. Additionally, the categories property in the Process class should be marked with @Published to ensure the UI updates reliably when it changes. Since these files were only moved and not modified in this PR, I'm unable to leave inline comments, but I strongly suggest addressing these points in a follow-up PR to improve the app's performance and robustness.

@ncooke3 ncooke3 requested review from andrewheard, daymxn and morganchen12 and removed request for andrewheard and daymxn December 11, 2025 22:08
@ncooke3 ncooke3 merged commit b4bc846 into main Dec 11, 2025
7 of 8 checks passed
@ncooke3 ncooke3 deleted the nc/perf-qs-modernize branch December 11, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants