Add Embeddable integration guide for connecting to Firebolt#94
Open
hjkmarshall wants to merge 2 commits intofirebolt-db:gh-pagesfrom
Open
Add Embeddable integration guide for connecting to Firebolt#94hjkmarshall wants to merge 2 commits intofirebolt-db:gh-pagesfrom
hjkmarshall wants to merge 2 commits intofirebolt-db:gh-pagesfrom
Conversation
| ```javascript | ||
| const apiKey = '<your API Key>'; | ||
| const connectionName = '<some unique name>'; | ||
| const BASE_URL = 'https://api.<your-region>.embeddable.com'; |
Contributor
There was a problem hiding this comment.
nit: Use the same naming style for variables
|
|
||
| ```javascript | ||
| const apiKey = '<your API Key>'; | ||
| const connectionName = '<some unique name>'; |
Contributor
There was a problem hiding this comment.
Looks like we define connection name here, but don't use it elsewhere. We can potentially use it in body.name field
Contributor
stepansergeevitch
left a comment
There was a problem hiding this comment.
Overall looks good!
stepansergeevitch
approved these changes
Jul 1, 2025
14d01d8 to
f28df46
Compare
92e0ddd to
ec77fc6
Compare
36386c9 to
47b4972
Compare
9e524b3 to
1c46eca
Compare
1c46eca to
afafd7d
Compare
2428d23 to
856b18d
Compare
2d29c15 to
02b89a4
Compare
d26a0bd to
ff0ba62
Compare
253400b to
37f16bd
Compare
28291ce to
18ae72b
Compare
18ae72b to
79bd303
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add Embeddable integration guide for connecting to Firebolt
Includes prerequisites, setup steps, API example, and links to further resources.
When should this PR be released to the public?
Immediate release.
Checklist below completed.
Documentation Checklist
make start-local(or using this tutorial)If this PR touches a function implementation (aggregate, scalar, or table-valued):
parentof my docs page is set correctly and the function shows up in the right category of the table of contents