refactor: use vmm_sys_util::timerfd module instead of timerfd crate #5424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The variant was only constructed in a single place, so just make the string that was passed there the display text for this error. Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
Use vmm_sys_util's timerfd implementation instead of the one in the timerfd crate. This eliminates a couple of dependencies, including an aesthetically unpleasing double-dependency on different versions of rustix. Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
roypat
force-pushed
the
rust-vmm-timerfd
branch
from
308d826 to
1be7df7
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5424 +/- ##
==========================================
- Coverage 82.73% 82.56% -0.18%
==========================================
Files 263 263
Lines 27455 27444 -11
==========================================
- Hits 22715 22658 -57
- Misses 4740 4786 +46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
roypat
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use vmm_sys_util's timerfd implementation instead of the one in the
timerfd crate. This eliminates a couple of dependencies, including an
aesthetically unpleasing double-dependency on different versions of
rustix.
This'll need to stay draft until rust-vmm/vmm-sys-util#254 is merged, a new vmm-sys-util release is made, and the entire rust-vmm ecosystem has updated to it (#5392), in which case the change to the top level Cargo.toml needs to be dropped.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.