Remove unused metrics and add test to ensure we don't introduce new ones #5439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5439 +/- ##
==========================================
- Coverage 82.68% 82.68% -0.01%
==========================================
Files 263 263
Lines 27473 27464 -9
==========================================
- Hits 22717 22708 -9
Misses 4756 4756
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Remove metrics that were never incremented. Closes firecracker-microvm#2901 Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
Add a test that fails if there are metrics that are never incremented in production code (e.g. outside of aggregation code and constructors). Closes firecracker-microvm#5182 Co-authored-by: Milan Dhaduk <mdhaduk7@gmail.com> Signed-off-by: Milan Dhaduk <mdhaduk7@gmail.com> Co-authored-by: LDagnachew <leulmdagnachew@gmail.com> Signed-off-by: LDagnachew <leulmdagnachew@gmail.com> Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
roypat
force-pushed
the
metrics-cleanup
branch
from
4168c69 to
1e58a18
Compare
roypat
added
the
Status: Awaiting review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of the work started in #5182. My main contribution is just code cleanup, and transforming the standalone test into a pytest integration test in the style group.
The output of the test when failing looks like this:
which can be easily tested by reverting the first commit in this PR, and running the test.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.