Minor refactor of rate limit tests #5440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadowCurse
force-pushed
the
rate_limit_test_refactor
branch
from
76f6eeb to
edd28fe
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5440 +/- ##
=======================================
Coverage 82.68% 82.68%
=======================================
Files 263 263
Lines 27478 27478
=======================================
Hits 22719 22719
Misses 4759 4759
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ShadowCurse
force-pushed
the
rate_limit_test_refactor
branch
2 times, most recently
from
1e26883 to
f89465f
Compare
Don't ask how it got that bad. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
There is no reason to do a single retry with specific time multiplier. If retry is indeed is needed it can be implemented with a simple loop inside or outside the function. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
Don't reuse iperf in the guest for RX tests since it was causing intermittent issues. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
With shorter name we can inline some functions in the next commit. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
The function is too small, so inline it. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
The duration was always the same, so no need to have it as an argument. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
The function is too small, so inline it. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
The duration was always the same, so no need to have it as an argument. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
Similar to the RX tests, in TX tests we can just use one shot servers on the host. This should prevent any instability with host iperf caused by reuse. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
force-pushed
the
rate_limit_test_refactor
branch
from
f89465f to
90c31c3
Compare
ShadowCurse
added
Status: Awaiting review
roypat
reviewed
Sep 15, 2025
roypat
previously approved these changes
Sep 15, 2025
bchalios
reviewed
Sep 15, 2025
Give a function more correct name and stop multiplying resulting value by 100. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
force-pushed
the
rate_limit_test_refactor
branch
from
c6ea143 to
dfd5113
Compare
bchalios
approved these changes
Sep 16, 2025
roypat
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
iperfservers on the host or guest for mutliple tests. Runiperfwith-1flag.Reason
There is an intermittent issue with guest
iperfserver becoming unresponsive. Attempt to fix it with using a fresh server for each test.License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.