Walkington C1 macroelement #155
Merged
+503
−93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbrubeck
force-pushed
the
pbrubeck/walkington
branch
from
ea693a1 to
64907c0
Compare
rckirby
requested changes
Jan 12, 2026
pbrubeck
commented
Jan 12, 2026
pbrubeck
commented
Jan 12, 2026
pbrubeck
commented
Jan 12, 2026
pbrubeck
commented
Jan 12, 2026
rckirby
approved these changes
Jan 12, 2026
rckirby
left a comment
rckirby
left a comment
There was a problem hiding this comment.
I have a minor preference for BidirectionalDerivative over SecondDerivative in the suggested changes and would advise cancelling them. But it's only a minor preference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the C1 tetrahedral macroelement without edge degrees of freedom from (Walkington, 2010)