Skip to content

Support ufl_element.quad_scheme #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rckirby merged 45 commits into from
Oct 14, 2025
Merged

Support ufl_element.quad_scheme #186

rckirby merged 45 commits into from
Oct 14, 2025

Conversation

@pbrubeck
Copy link

@pbrubeck pbrubeck commented Sep 30, 2025 •
edited
Loading

This enables integral moment DOFs defined on composite rules, which are useful for interpolating macroelements into non-macroelements.

V = FunctionSpace(mesh, FiniteElement("CG", degree=2, variant="integral", quad_scheme="iso"))

@pbrubeck pbrubeck changed the title Element Factory: pass quad_scheme Support ufl_element.quad_scheme Sep 30, 2025
@pbrubeck pbrubeck force-pushed the pbrubeck/quad-scheme branch from 8f7a1d8 to 2c295ab Compare September 30, 2025 14:38
@pbrubeck pbrubeck force-pushed the pbrubeck/quad-scheme branch from 2c295ab to 5a6c6e3 Compare September 30, 2025 14:48
pbrubeck added 25 commits October 1, 2025 20:13
@pbrubeck
Quadrature elements constructed from non-Lagrange elements
8afe3e1
@pbrubeck
Negative integral variant to specify moments against lower order poly…
e57c0a1 
…nomials
@pbrubeck
Merge branch 'pbrubeck/quad-scheme' into pbrubeck/quad-element
f6b2712
@pbrubeck
Remove repeated points from dual_basis
a28c83a
@pbrubeck
CrouzeixRaviart: support quad_scheme
f803556
@pbrubeck
RestrictedElement: support restriction_domain=ridge
3907eb8
@pbrubeck
Fix up
942e628
@pbrubeck
Fix tolerance
54dbff9
@pbrubeck
drop unrelated files
2095be3
@pbrubeck
Extended support for quad_scheme
7662e0a
@pbrubeck
drop unrelated files
4197052
@pbrubeck
drop unrelated files
95032e9
@pbrubeck
Merge branch 'main' into pbrubeck/quad-element
0c0fcef
@pbrubeck
Merge branch 'main' into pbrubeck/quad-scheme
d05358b
@pbrubeck
element_factory: pass quad_scheme to finat_constructor
39e156f
@pbrubeck
drop unrelated files
6a167d6
@pbrubeck
Enable quad_scheme on the de Rham complex
bef6ed7
@pbrubeck
quad_scheme on more elements
26251d9
@pbrubeck
Fixup
6ecf3a3
@pbrubeck
Fixup
bca20b8
@pbrubeck
Support more elements
d181613
@pbrubeck
merge conflict
94cde5f
@pbrubeck
drop unrelated file
22851d4
@pbrubeck
Merge branch 'main' into pbrubeck/quad-scheme
421d9df
@pbrubeck
Macro KMV
14dc9e7
@pbrubeck pbrubeck force-pushed the pbrubeck/quad-scheme branch from 53a1c66 to 1b5d149 Compare October 9, 2025 15:22
@pbrubeck pbrubeck mentioned this pull request Oct 9, 2025
Closed
@pbrubeck pbrubeck force-pushed the pbrubeck/quad-scheme branch from 8beb95c to ceea2cb Compare October 9, 2025 17:54
pbrubeck
pbrubeck commented Oct 9, 2025
View reviewed changes
pbrubeck
pbrubeck commented Oct 9, 2025
View reviewed changes
@pbrubeck pbrubeck force-pushed the pbrubeck/quad-scheme branch from 46d442f to 49f005c Compare October 11, 2025 09:00
rckirby
rckirby requested changes Oct 13, 2025
View reviewed changes
Copy link

@rckirby rckirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments. Plus, are we testing Firedrake against this?

@pbrubeck
Copy link
Author

pbrubeck commented Oct 13, 2025

A few comments. Plus, are we testing Firedrake against this?

Test are here
firedrakeproject/firedrake#4635

@pbrubeck pbrubeck requested a review from rckirby October 14, 2025 13:07
@pbrubeck
Copy link
Author

pbrubeck commented Oct 14, 2025

Test are passing https://github.com/firedrakeproject/firedrake/actions/runs/18356515006/job/52695246628?pr=4635

@rckirby rckirby merged commit 4fe4d69 into main Oct 14, 2025
8 checks passed
@rckirby rckirby deleted the pbrubeck/quad-scheme branch October 14, 2025 16:59
@pbrubeck pbrubeck mentioned this pull request Oct 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rckirby rckirby rckirby approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pbrubeck @rckirby