Move Firedrake code from ngsPETSc into Firedrake #4782
Merged
+672
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should break a tricky dependency cycle.
This was referenced Dec 18, 2025
Merged
dham
requested changes
Jan 6, 2026
connorjward
added a commit
to NGSolve/ngsPETSc
that referenced
this pull request
Jan 8, 2026
* Remove Firedrake-specific code as it has been moved into Firedrake in firedrakeproject/firedrake#4782
lrtfm
reviewed
Jan 11, 2026
| # NB: Coordinates must be cast to real when running Firedrake in complex mode | ||
| permutation = find_permutation( | ||
| physical_space_points, | ||
| new_coordinates.dat.data[pyop2_index].reshape( |
Contributor
There was a problem hiding this comment.
new_coordinates.dat.data[pyop2_index].real.reshape(
Cast coordinates to real to avoid ComplexWarning in complex mode
Contributor
Author
There was a problem hiding this comment.
Thanks for raising this. Please see #4815
Note that in future we would be very happy to receive PRs fixing this sort of thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should break a tricky dependency cycle.
Goes with NGSolve/ngsPETSc#99
TODO: how to make sure credit is appropriately given?