Skip to content

Conversation

@greguintow
Copy link
Contributor

@greguintow greguintow commented Jan 29, 2026

What does this PR do?

  • Update to publish to github registry first

Type of change

This pull request is a

  • Feature
  • Bugfix
  • Enhancement

Which introduces

  • Breaking changes
  • Non-breaking changes

Any background context you want to provide beyond Shortcut?

The npm token is expired, to unblock the use of the package, releasing to github registry and will fix the npm one afterwards


Open with Devin

Summary by CodeRabbit

  • Chores
    • Improved the package publishing workflow to better handle version management across registries.
    • Enhanced prerelease version handling during the publish process.
    • Streamlined publishing logic by removing redundant configuration.

✏️ Tip: You can customize this high-level summary in your review settings.

@fireflies-bot
Copy link

@coderabbitai
Copy link

coderabbitai bot commented Jan 29, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

GitHub Actions workflow enhancement in the CD pipeline that adds .npmrc creation for GitHub Package Registry, implements conditional publishing with version existence checking, handles prerelease tags by extracting identifiers, and consolidates duplicate publishing blocks while managing authentication tokens.

Changes

Cohort / File(s) Summary
CD Workflow Publishing Enhancement
.github/workflows/cd.yml
Added .npmrc creation for GitHub Package Registry, conditional publishing logic with version existence checks via npm view, prerelease tag extraction and application, .npmrc removal before npm publishing, and consolidation of previously duplicated GitHub Package Registry publish blocks.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes


Comment @coderabbitai help to get the list of available commands and usage tips.

@greguintow greguintow merged commit 5d34771 into develop Jan 29, 2026
4 of 5 checks passed
@fireflies-bot
Copy link

🔍 PR Complexity Assessment

🟢 Risk Score: 2/10

[██░░░░░░░░]

📝 Summary

This PR reorders the CI/CD workflow to publish to GitHub Package Registry before NPM registry, as a workaround for an expired NPM token. The actual logic remains the same, just the execution order is changed.

📊 Lines Analysis

Metric Count
Total Changes 83
Production Code 83
Test Code 0

💡 Recommendation

This is a low-risk change that simply reorders existing CI/CD steps. The GitHub Package Registry publish step is moved before the NPM publish step. Verify that the workflow runs correctly after merging to ensure packages are published as expected.


This assessment is automated and should be used as a guide. Please use your judgment when reviewing.

Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional flags.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants