fix: register exception handlers and fix handle_plural_values() white spaces#306
Open
vidhip222 wants to merge 1 commit intofireform-core:mainfrom
Open
fix: register exception handlers and fix handle_plural_values() white spaces#306vidhip222 wants to merge 1 commit intofireform-core:mainfrom
vidhip222 wants to merge 1 commit intofireform-core:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bug fixes to the LLM data extraction pipeline and API error handling.
The previous loop started at index i+1, leaving values[0] (the first LLM-extracted value) never stripped. It also only applied lstrip(), missing trailing whitespace. Replaced with a list comprehension using str.strip() that correctly cleans all values and filters out empty entries from trailing semicolons. Also adds type hints (str -> list[str]) and fixes a typo in the log message.
Register_exception_handlers() was defined in api/errors/handlers.py but never called on app startup, so AppError exceptions (e.g. 404 for missing templates) were unhandled by FastAPI and returned as 500 errors instead of the intended status codes.
Issues:
Fixes #283
Fixes #295
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: