fix: add input validation and tests for /forms/fill endpoint#308
Open
Mahendrareddy2006 wants to merge 9 commits intofireform-core:mainfrom
Open
fix: add input validation and tests for /forms/fill endpoint#308Mahendrareddy2006 wants to merge 9 commits intofireform-core:mainfrom
Mahendrareddy2006 wants to merge 9 commits intofireform-core:mainfrom
Conversation
added 9 commits
March 17, 2026 11:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances the
/forms/fillendpoint by introducing proper input validation and improving overall request handling reliability. It ensures that invalid or malformed requests are rejected early, preventing unnecessary processing and potential downstream failures.#Changes
Added validation to reject empty or whitespace-only 'input_text'
Added validation to ensure 'template_id' is valid (non-null and positive)
Introduced an optional upper limit on input length to prevent excessively large payloads
Improved error handling using consistent 'AppError' responses with appropriate status codes (400)
Removed redundant database calls by avoiding duplicate template fetching
Added unit tests covering:
#Why
Previously, the endpoint accepted invalid inputs such as empty text or incorrect template IDs. This could lead to:
By validating inputs at the API boundary, we ensure that only meaningful and processable requests reach the business logic layer.
Result
400 Bad Requestresponses for invalid inputsNotes