fix: avoid commonforms import crash on app startup#321
Open
lil-aditya wants to merge 1 commit intofireform-core:mainfrom
Open
fix: avoid commonforms import crash on app startup#321lil-aditya wants to merge 1 commit intofireform-core:mainfrom
lil-aditya wants to merge 1 commit intofireform-core:mainfrom
Conversation
Root cause: src/file_manipulator.py imported commonforms at module import time. commonforms pulls in ultralytics/cv2/numpy which can crash or fail to import in minimal environments (e.g. missing libGL in Docker), taking down the FastAPI app during import. Solution: introduce src/pdf_template.py with a lazy importer (prepare_form_safe) and route template creation through it. This keeps template creation behavior unchanged while ensuring api.main can be imported without triggering the heavy dependency chain. Tests: add regression test ensuring api.main import does not import commonforms; update template route test to stub template creation and avoid environmental dependency on OpenCV.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Importing the backend (
import api.main) can crash in minimal or production environments.Root Cause
src/file_manipulator.pyimportscommonformsat module import timecommonformspulls heavy dependencies:ultralytics → cv2 → numpylibGLin Docker)Result: FastAPI app crashes during import, even if template functionality is not used
Solution
Closes #320