feat: add implicit conversion from TypeIdDecoded to Guid#26
Open
Hanskrogh wants to merge 1 commit intofirenero:mainfrom
Open
feat: add implicit conversion from TypeIdDecoded to Guid#26Hanskrogh wants to merge 1 commit intofirenero:mainfrom
Hanskrogh wants to merge 1 commit intofirenero:mainfrom
Conversation
firenero
reviewed
Sep 30, 2024
Owner
firenero
left a comment
There was a problem hiding this comment.
Thanks for submitting the PR and sorry for a very long response. I don't mind including that change if you can clean up the PR a bit:
- Remove all unnecessary whitespace changes in it.
- Use expression body syntax in implicit operator implementation for consistency (similarly to other one-line method implementations).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benefits: