[pull] master from prestodb:master#550
Merged
pull[bot] merged 3 commits intofishbone:masterfrom Feb 5, 2026
Merged
Conversation
## Description Fixes Velox to Presto `IN` expression conversion. When the `IN-list` is constant, the Velox expression representation uses a constant expression with an array vector to store the list (see conversion [here](https://github.com/prestodb/presto/blob/4e91f155d0f4704325552fac3807da0efdba6a35/presto-native-execution/presto_cpp/main/types/PrestoToVeloxExpr.cpp#L780)). The Presto `IN` expression expects the values from constant `IN-list` to be distinct arguments to the `SpecialFormExpression`. The `VeloxToPrestoExpr` is modified accordingly. ## Motivation and Context Resolves #26921. ## Impact Fixes bug with `IN` expression in native expression optimizer. ## Test Plan Added e2e test. ``` == NO RELEASE NOTE == ``` ## Summary by Sourcery Fix Velox-to-Presto conversion of IN expressions to correctly construct Presto special form arguments and add coverage for the native expression optimizer. Bug Fixes: - Correct Velox IN expression conversion when the IN-list is represented as a constant array so Presto receives individual arguments instead of a single array-typed constant. Tests: - Add an end-to-end test ensuring IN expressions are handled correctly by the native expression optimizer in the sidecar plugin test suite.
…26978) ## Description Velox now supports `KHyperLogLog` type (ref: facebookincubator/velox@1165703). Adds support for this type to the `NativeTypeManager`. Also adds `KHyperLogLog` to `StandardTypes` in `presto-common` to avoid a dependency on `presto-main-base` in `presto-native-sidecar-plugin`. ## Motivation and Context Fix test failure uncovered in `presto-native-tests`. Required for #23671. ## Impact Queries with `KHyperLogLog` won't fail on sidecar enabled Presto C++ deployments. ## Test Plan Added e2e test. ``` == NO RELEASE NOTE == ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )