Skip to content

Conversation

@Qizot
Copy link

@Qizot Qizot commented Jan 28, 2026

Description

This PR adds docs related to data channels in web sdk.

@linear
Copy link

linear bot commented Jan 28, 2026

@Qizot Qizot requested a review from Copilot January 28, 2026 15:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds comprehensive documentation for data channels in the web SDK, enabling developers to send and receive arbitrary binary data between peers in a room.

Changes:

  • Added new documentation page explaining data channel concepts and usage patterns
  • Updated connecting guide to reference the new data channels documentation
  • Updated subproject commit references for web-client-sdk, python-server-sdk, js-server-sdk, protos, and fishjam-server

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
docs/how-to/client/data-channels.mdx New documentation covering data channel types, broadcast communication, and implementation examples for chat and cursor sharing
docs/how-to/client/connecting.mdx Added reference link to data channels documentation in the next steps section
packages/web-client-sdk Updated subproject commit reference
packages/python-server-sdk Updated subproject commit reference
packages/js-server-sdk Updated subproject commit reference
api/protos Updated subproject commit reference
api/fishjam-server Updated subproject commit reference

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@czerwiukk czerwiukk assigned Qizot and unassigned czerwiukk Jan 28, 2026
@czerwiukk czerwiukk self-requested a review January 28, 2026 17:06
Copy link
Member

@czerwiukk czerwiukk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to put the docs in the "how to" section, it could be something like "how to build a text chat". The explanation of what a data channel actually is and how it works falls better into the Explanation category.
We follow https://diataxis.fr/ approach for our docs. I should've shared this earlier, but forgor, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants