SDK Deprecation message Authentication #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
Adds an SDK deprecation/compatibility payload to the peer authentication response so clients can be informed when their SDK version is up-to-date, deprecated, or unsupported.
Changes:
- Introduces
PeerMessage.SdkDeprecationmessage andStatusenum inpeer_notifications.proto. - Extends
PeerMessage.Authenticatedwith a newsdk_deprecationfield. - Regenerates Elixir protobuf modules and updates generated protocol documentation.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| fishjam_protos/lib/fishjam/peer_notifications.pb.ex | Adds generated Elixir modules for SdkDeprecation and wires the new field into Authenticated. |
| fishjam/peer_notifications.proto | Defines the new SdkDeprecation message/enum and adds it to Authenticated. |
| doc/docs.md | Updates the generated protocol docs/TOC to include SdkDeprecation and the new field. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Karolk99
approved these changes
Jan 27, 2026
Comment on lines
+26
to
+28
|
|
||
| Status status = 1; | ||
| string message = 2; |
Collaborator
There was a problem hiding this comment.
What will be sent in the message? Which version is supported?
Member
Author
There was a problem hiding this comment.
message displayed to sdk user
Member
Author
There was a problem hiding this comment.
support for version is defined in PR to fishtank https://github.com/fishjam-cloud/fishtank/pull/49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe your changes.
Motivation and Context
Why is this change required? What problem does it solve? If it fixes an open
issue, please link to the issue here.
Documentation impact