Skip to content

Fixed recalculation coordinates of element every time when spy handler is invoked #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed recalculation coordinates of element every time when spy handler is invoked #377

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions modules/mixins/scroll-link.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,12 @@ export default (Component, customScroller) => {
const scroller = customScroller || defaultScroller;

class Link extends React.PureComponent {
element = null;
elementBounds = {
topBound: 0,
bottomBound: 0,
}

constructor(props) {
super(props);
this.state = {
Expand Down Expand Up @@ -75,9 +81,9 @@ export default (Component, customScroller) => {
}

let to = this.props.to;
let element = null;
let elemTopBound = 0;
let elemBottomBound = 0;
let element = this.element;
let elemTopBound = this.elementBounds.topBound;
let elemBottomBound = this.elementBounds.bottomBound;
let containerTop = 0;

if (scrollSpyContainer.getBoundingClientRect) {
Expand All @@ -92,6 +98,12 @@ export default (Component, customScroller) => {
let cords = element.getBoundingClientRect();
elemTopBound = (cords.top - containerTop + y);
elemBottomBound = elemTopBound + cords.height;

this.element = element
this.elementBounds = {
topBound: elemTopBound,
bottomBound: elemBottomBound
}
}

let offsetY = y - this.props.offset;
Expand Down