Skip to content

fix: hide grid cursor highlight when unfocused #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fissible merged 2 commits into from
Apr 4, 2026
Merged

fix: hide grid cursor highlight when unfocused #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6244445
fix: hide grid cursor highlight when grid is unfocused
fissible Apr 3, 2026
02a056a
fix: draw immediately after global quit handler activates an overlay
fissible Apr 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/shell.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,6 +635,11 @@ shellframe_shell() {
_current="$_SHELLFRAME_SHELL_NEXT"
_SHELLFRAME_SHELL_NEXT=""
_screen_done=1
else
# _quit activated an overlay (e.g. confirm dialog) without
# navigating screens — draw immediately so the overlay is
# visible before the next key is read.
_shellframe_shell_draw_if_dirty "$_prefix" "$_current"
fi
else
_current="__QUIT__"; _screen_done=1
Expand Down
3 changes: 0 additions & 3 deletions src/widgets/grid.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,9 +326,6 @@ shellframe_grid_render() {
local _row_bg="$_grid_bg"
if (( _is_cursor && ${SHELLFRAME_GRID_FOCUSED:-0} )); then
_row_bg="${SHELLFRAME_GRID_CURSOR_STYLE:-$_rev}"
elif (( _is_cursor )); then
# Unfocused cursor — subtle dark-gray highlight
_row_bg=$'\033[48;5;236m'
elif [[ -n "${SHELLFRAME_GRID_STRIPE_BG:-}" ]] && (( _ridx % 2 == 1 )); then
_row_bg="$SHELLFRAME_GRID_STRIPE_BG"
fi
Expand Down
Loading