fix: remove admin user creation todo comment#144
Open
galexrt wants to merge 1 commit intofivemanage:developfrom
Open
fix: remove admin user creation todo comment#144galexrt wants to merge 1 commit intofivemanage:developfrom
galexrt wants to merge 1 commit intofivemanage:developfrom
Conversation
The CreateAdminUser() call already checks if an admin user exists or not before creating a new one. Signed-off-by: Alexander Trost <galexrt@googlemail.com>
There was a problem hiding this comment.
Pull request overview
This PR removes an outdated TODO comment in cmd/lite/lite.go that described checking for and creating an admin user. The CreateAdminUser() function already implements the described behavior — checking if an admin exists before creating one.
Changes:
- Removed a stale TODO comment that was already resolved by the existing
CreateAdminUser()implementation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CreateAdminUser() call already checks if an admin user exists or not before creating a new one.
While working on making some changes I saw the comment and that it seems already resolved.