Remove engagement, contact list deprecated fields + old was_unsubscribed field in email events#194
Conversation
…an/dbt_hubspot into sunset/deprecation-fields
…an/dbt_hubspot into sunset/deprecation-fields
CHANGELOG.md
Outdated
|
|
||
| | Data Model(s) | Change type | Old | New | Notes | | ||
| | ---------- | ----------- | -------- | -------- | ----- | | ||
| | `hubspot__email_sends` | Removed column | `was_unsubcribed` | | Field deprecated in [v1.5.0](https://github.com/fivetran/dbt_hubspot/releases/tag/v1.5.0) has been sunset. Use `was_unsubscribed` instead. | |
There was a problem hiding this comment.
I would just emphasize it is a spelling correction.
| | `hubspot__email_sends` | Removed column | `was_unsubcribed` | | Field deprecated in [v1.5.0](https://github.com/fivetran/dbt_hubspot/releases/tag/v1.5.0) has been sunset. Use `was_unsubscribed` instead. | | |
| | `hubspot__email_sends` | Removed column | `was_unsubcribed` | | Field deprecated in [v1.5.0](https://github.com/fivetran/dbt_hubspot/releases/tag/v1.5.0) has been sunset. Use the corrected spelling `was_unsubscribed` instead. | |
CHANGELOG.md
Outdated
| | Data Model(s) | Change type | Old | New | Notes | | ||
| | ---------- | ----------- | -------- | -------- | ----- | | ||
| | `hubspot__email_sends` | Removed column | `was_unsubcribed` | | Field deprecated in [v1.5.0](https://github.com/fivetran/dbt_hubspot/releases/tag/v1.5.0) has been sunset. Use `was_unsubscribed` instead. | | ||
| | `hubspot__engagements` | Removed columns | `owner_id`<br>`is_active`<br>`created_timestamp`<br>`occurred_timestamp`<br>`activity_type`<br>`last_updated_timestamp` | | Fields deprecated for HubSpot v3 API connectors have been sunset. The `engagement` source table now only contains `type`, `id`, `_fivetran_synced`, `portal_id`, and `source_relation`. All engagement properties (timestamps, owner, status) are available in child engagement tables (e.g., `hubspot__engagement_emails`, `hubspot__engagement_notes`). Junction table aggregations (`contact_ids`, `deal_ids`, `company_ids`) remain available in `hubspot__engagements`. | |
There was a problem hiding this comment.
If there is a link that talks about the v3 deprecations, let's link that.
There was a problem hiding this comment.
Added links to relevant release notes in each row.
macros/engagements_joined.sql
Outdated
| select | ||
| {{ dbt_utils.star(from=base_model, relation_alias="base",except=["_fivetran_deleted", "created_timestamp", "occurred_timestamp", "owner_id"]) }}, | ||
| select | ||
| {{ dbt_utils.star(from=base_model, relation_alias="base", except=["_fivetran_deleted", "created_timestamp", "occurred_timestamp", "owner_id"]) }}, |
There was a problem hiding this comment.
I know we discussed this at standup, but I'm not seeing the risk in streamlining this a bit. The compiled code is effectively the same since unless I'm missing something.
| {{ dbt_utils.star(from=base_model, relation_alias="base", except=["_fivetran_deleted", "created_timestamp", "occurred_timestamp", "owner_id"]) }}, | |
| {{ dbt_utils.star(from=base_model, relation_alias="base", except=["_fivetran_deleted"]) }}, |
There was a problem hiding this comment.
Found some earlier notes that confirmed that these fields are fully sunset, so I went ahead and removed everything from the except statement besides _fivetran_deleted.
macros/engagements_joined.sql
Outdated
| base.created_timestamp, | ||
| base.occurred_timestamp, | ||
| base.owner_id |
There was a problem hiding this comment.
I think this might be a bit confusing if we don't remove them in the future, but again let me know if this must stay. If they have to stay I would add a comment as to why these are down here.
| base.created_timestamp, | |
| base.occurred_timestamp, | |
| base.owner_id |
There was a problem hiding this comment.
Went ahead and removed.
…an/dbt_hubspot into sunset/deprecation-fields
fivetran-avinash
left a comment
There was a problem hiding this comment.
@fivetran-catfritz Suggested changes applied, should be ready for re-review when you get back!
fivetran-catfritz
left a comment
There was a problem hiding this comment.
A few changelog suggestions but otherwise approved!
Co-authored-by: fivetran-catfritz <111930712+fivetran-catfritz@users.noreply.github.com>
PR Overview
Package version introduced in this PR:
This PR addresses the following Issue/Feature(s):
ENGAGEMENTsource #174, [Deprecation] CONTACT_LIST Fields #175, [SUNSET] Removewas_unsubcribedfromhubspot__email_sends#190Summary of changes:
Submission Checklist
Changelog