Skip to content

bugfix/cast_fields_as_float#26

Merged
fivetran-savage merged 8 commits intomainfrom
bugfix/cast_fields_as_float
Apr 16, 2026
Merged

bugfix/cast_fields_as_float#26
fivetran-savage merged 8 commits intomainfrom
bugfix/cast_fields_as_float

Conversation

@fivetran-savage
Copy link
Copy Markdown
Contributor

@fivetran-savage fivetran-savage commented Apr 14, 2026

PR Overview

Package version introduced in this PR:

  • 1.2.1

This PR addresses the following Issue/Feature(s):

Summary of changes:

  • Casts duration_in_seconds and progress fields in qualtrics__contact and qualtrics__survey models to float.
  • Casts time_to_open_in_seconds, time_to_start_in_seconds, and time_to_complete_in_seconds in qualtrics__distribution model to float.

Submission Checklist

  • Alignment meeting with the reviewer (if needed)
    • Timeline and validation requirements discussed
  • Provide validation details:
    • Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
    • Testing Instructions: Confirm the change addresses the issue(s)
    • Focus Areas: Complex logic or queries that need extra attention
  • Merge any relevant open PRs into this PR

Changelog

  • Draft changelog for PR
  • Final changelog for release review

@fivetran-savage fivetran-savage marked this pull request as ready for review April 15, 2026 18:08
@fivetran-savage fivetran-savage self-assigned this Apr 15, 2026
@fivetran-savage fivetran-savage added the docs:ready Triggers the docs generator workflow. label Apr 15, 2026
Copy link
Copy Markdown
Contributor

@fivetran-catfritz fivetran-catfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Reminder to re-generate the docs.

@fivetran-savage fivetran-savage added docs:ready Triggers the docs generator workflow. and removed docs:ready Triggers the docs generator workflow. labels Apr 16, 2026
@fivetran-savage fivetran-savage merged commit 2221290 into main Apr 16, 2026
9 checks passed
@fivetran-savage fivetran-savage deleted the bugfix/cast_fields_as_float branch April 16, 2026 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs:ready Triggers the docs generator workflow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants