Skip to content
This repository was archived by the owner on Jan 20, 2026. It is now read-only.

feature/text-column-addition#16

Merged
fivetran-joemarkiewicz merged 10 commits intomainfrom
feature/text-column-addition
Jul 17, 2025
Merged

feature/text-column-addition#16
fivetran-joemarkiewicz merged 10 commits intomainfrom
feature/text-column-addition

Conversation

@fivetran-joemarkiewicz
Copy link
Copy Markdown
Collaborator

@fivetran-joemarkiewicz fivetran-joemarkiewicz commented Jul 16, 2025

PR Overview

Package version introduced in this PR: v0.4.0

This PR addresses the following Issue/Feature(s): Issue #15

Summary of changes:

Introduction of the text field as the response_text column in the stg_qualtrics__question_response model.

Submission Checklist

  • Alignment meeting with the reviewer (if needed)
    • Timeline and validation requirements discussed
  • Provide validation details:
    • Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
      • Confirmed downstream validation tests succeed (see downstream PR).
      • Additionally verified BK passes with seed file updates.
      • Finally, confirmed locally this succeeds as expected by having the column accurately reflected in the staging model. See internal ticket for more details.
    • Testing Instructions: Confirm the change addresses the issue(s)
      • Run the package updates locally and see success and new column added.
    • Focus Areas: Complex logic or queries that need extra attention
      • No major focus area other than confirming the column is recreated successfully in the staging model.

Changelog

  • Draft changelog for PR
  • Final changelog for release review

* Q2 FY26: Apply automated update.

* Update CHANGELOG.md

---------

Co-authored-by: fivetran-catfritz <111930712+fivetran-catfritz@users.noreply.github.com>
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
Comment thread CHANGELOG.md Outdated
Comment thread README.md
Copy link
Copy Markdown
Contributor

@fivetran-avinash fivetran-avinash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-joemarkiewicz One README request but approved!

@fivetran-joemarkiewicz fivetran-joemarkiewicz added the docs:ready Triggers the docs generator workflow. label Jul 16, 2025
Copy link
Copy Markdown
Contributor

@fivetran-catfritz fivetran-catfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small question and left the suggestion we discussed, but nothing stopping release!

Comment thread README.md Outdated
Comment thread CHANGELOG.md Outdated
[PR #16](https://github.com/fivetran/dbt_qualtrics_source/pull/16) and [PR #17](https://github.com/fivetran/dbt_qualtrics_source/pull/17) include the following updates:

## Schema & Data Updates
**1 new column introduced and 1 schema change**
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we call this out as a breaking change?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since no jobs will actually break as a result of this new column, I opted to call it out as a schema change instead. For existing users there's no need to take action unless they want to leverage the new field.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the wording of this section to be more clear about the schema change and how it's not actually a breaking change.

fivetran-joemarkiewicz and others added 4 commits July 17, 2025 09:18
Co-authored-by: fivetran-catfritz <111930712+fivetran-catfritz@users.noreply.github.com>
@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit 1659c0f into main Jul 17, 2025
8 checks passed
@fivetran-joemarkiewicz fivetran-joemarkiewicz deleted the feature/text-column-addition branch July 17, 2025 14:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

docs:ready Triggers the docs generator workflow.

Projects

None yet

4 participants