Conversation
fivetran-savage
left a comment
fivetran-savage
left a comment
There was a problem hiding this comment.
A couple of questions and a few places in the yml where you need to add the source_relation column.
| created_by_id, | ||
| cast(created_date as {{ dbt.type_timestamp() }}) as created_date, | ||
| current_term, | ||
| cast(current_term as {{ dbt.type_int() }}) as current_term, |
There was a problem hiding this comment.
Were some of the _term fields coming through as different data types?
There was a problem hiding this comment.
I was testing the missing table capability of union data, and noticed that even though the fields CTE includes explicit casting, the warehouse sometimes still assigns its own datatype when a column is entirely null. This casting was necessary to prevent downstream errors in these lines of zuora__subscription_overview, where multiplications can fail if the warehouse interprets a null column as a string.
There was a problem hiding this comment.
Interesting. I saw this issue in recharge as well and did some extra casting.
| status, | ||
| subscription_end_date, | ||
| subscription_start_date, | ||
| cast(subscription_end_date as {{ dbt.type_timestamp() }}) as subscription_end_date, |
There was a problem hiding this comment.
Was this field previously a date or has it always been a timestamp?
| subscription_end_date, | ||
| subscription_start_date, | ||
| cast(subscription_end_date as {{ dbt.type_timestamp() }}) as subscription_end_date, | ||
| cast(subscription_start_date as {{ dbt.type_timestamp() }}) as subscription_start_date, |
There was a problem hiding this comment.
Same question as end_date.
There was a problem hiding this comment.
Same as above but for these lines.
| @@ -261,7 +263,6 @@ models: | |||
| - name: invoice_item_id | |||
There was a problem hiding this comment.
Add source_relation column name and description.
There was a problem hiding this comment.
Thanks! I have updated.
| @@ -408,7 +409,6 @@ models: | |||
| - name: account_monthly_id | |||
There was a problem hiding this comment.
Add source_relation column name and description.
There was a problem hiding this comment.
Thanks! I have updated.
models/zuora.yml
Outdated
| @@ -450,10 +450,9 @@ models: | |||
| - name: zuora__subscription_overview | |||
| description: Each record is a subscription, enhanced with additional details from rate plan charges and amendments. | |||
| columns: | |||
There was a problem hiding this comment.
add source_relation column name and description.
There was a problem hiding this comment.
Thanks! I have updated.
Co-authored-by: Savage Fivetran <sarah.savage@fivetran.com>
2 participants
PR Overview
Package version introduced in this PR:
This PR addresses the following Issue/Feature(s):
Summary of changes:
Submission Checklist
Changelog