Add backend parameter to detect_equilibration_window for optional numba dependencyupdate#10
Closed
xiki-tempula wants to merge 1 commit intofjclark:mainfrom
Closed
Add backend parameter to detect_equilibration_window for optional numba dependencyupdate#10xiki-tempula wants to merge 1 commit intofjclark:mainfrom
backend parameter to detect_equilibration_window for optional numba dependencyupdate#10xiki-tempula wants to merge 1 commit intofjclark:mainfrom
Conversation
xiki-tempula
force-pushed
the
feat_numba
branch
from
74a1842 to
d00b2b5
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
===========================================
- Coverage 100.00% 99.19% -0.81%
===========================================
Files 10 10
Lines 646 745 +99
===========================================
+ Hits 646 739 +93
- Misses 0 6 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Owner
|
Thanks very much for this! Before I review in detail, could you please comment on the speed differences? If I run the tests on |
Author
|
Thanks for flagging this - that's a significant slowdown and definitely not expected! |
Owner
|
Thanks! I see this slow-down consistently:
On my ubuntu workstation:
Latest version: 0.63.1
Yes, this returns True. Here's the full environment on my ubuntu workstation: |
Author
|
I cannot really reproduce the slowdown, given that the speed improvement is not big big, I think I will just close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
backendparameter todetect_equilibration_windowthat allows choosing between"numba"(default) and"numpy"backendsMotivation
This change allows users who don't have numba installed (or don't want to use it) to still use
detect_equilibration_window. The numpy backend provides a pure Python/numpy implementation that works without any additional dependencies.Changes
red/variance.py:_optional_njitdecorator that applies numba JIT only when available_compute_variance_series_window_numpy- pure numpy implementation_compute_variance_series_window_indexed- numba parallel implementationbackendparameter toget_variance_series_windowred/sse.py: Addedbackendparameter toget_sse_series_windowred/equilibration.py: Addedbackendparameter todetect_equilibration_windowred/tests/test_equilibration.py: Addedtest_detect_equilibration_window_backendsto verify both backends produce identical resultsUsage