Skip to content

Upgrade code to support OpenCV 3 on ROS Melodic#1

Open
abougouffa wants to merge 2 commits intofjperezgrau:opencv3from
abougouffa:opencv3
Open

Upgrade code to support OpenCV 3 on ROS Melodic#1
abougouffa wants to merge 2 commits intofjperezgrau:opencv3from
abougouffa:opencv3

Conversation

@abougouffa
Copy link
Copy Markdown

Some modifications to viodom to be compiled with OpenCV 3 on ROS Melodic.

@fjperezgrau
Copy link
Copy Markdown
Owner

fjperezgrau commented Apr 30, 2020

Thanks a lot for your contribution @abougouffa. I have created a branch called opencv3 so please could you do the pull request on that branch instead of the master branch?

@abougouffa abougouffa changed the base branch from master to opencv3 April 30, 2020 22:07
@abougouffa
Copy link
Copy Markdown
Author

You are welcome, thank you for sharing your code @fjperezgrau
It is done 😃

@fjperezgrau
Copy link
Copy Markdown
Owner

Thanks again. After reviewing the commits, I realized that the vast majority of changes are caused by format settings. In order to keep the same style, since other colleagues are using this, I'd kindly ask you to submit the minimal changes needed to compile and use the package with OpenCV3 and ROS melodic, i.e. changes in CMakelists.txt and src/robustmatcher.hpp are fine, but changes in src/stereodom.hpp are far more than the necessary ones for using the new features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants