Upgrade code to support OpenCV 3 on ROS Melodic#1
Open
abougouffa wants to merge 2 commits intofjperezgrau:opencv3from
Open
Upgrade code to support OpenCV 3 on ROS Melodic#1abougouffa wants to merge 2 commits intofjperezgrau:opencv3from
abougouffa wants to merge 2 commits intofjperezgrau:opencv3from
Conversation
Owner
|
Thanks a lot for your contribution @abougouffa. I have created a branch called |
Author
|
You are welcome, thank you for sharing your code @fjperezgrau |
Owner
|
Thanks again. After reviewing the commits, I realized that the vast majority of changes are caused by format settings. In order to keep the same style, since other colleagues are using this, I'd kindly ask you to submit the minimal changes needed to compile and use the package with OpenCV3 and ROS melodic, i.e. changes in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some modifications to
viodomto be compiled with OpenCV 3 on ROS Melodic.