Skip to content
This repository was archived by the owner on Jan 22, 2026. It is now read-only.

Conversation

@fkodom
Copy link
Owner

@fkodom fkodom commented Apr 2, 2025

  • Install and run with uv
  • Update the test-slow and publish workflows to use uv as well

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @fkodom, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request switches the GitHub Actions workflows to use uv instead of pip for installing dependencies and building/publishing the package. This should improve the speed and efficiency of the workflows. The workflows modified are publish.yaml and test-slow.yaml.

Highlights

  • Workflow Update: The pull request updates the GitHub Actions workflows to use uv for dependency management.
  • Performance Improvement: Switching to uv should result in faster installation and build times in the CI/CD pipeline.
  • Python Version: The publish workflow updates the python version to 3.11

Changelog

  • .github/disabled-workflows/publish.yaml
    • Replaced actions/setup-python with astral-sh/setup-uv to install uv.
    • Changed the Python version to 3.11.
    • Modified the 'Build and Publish' step to use uv build and uv publish instead of python -m build and pypa/gh-action-pypi-publish.
  • .github/disabled-workflows/test-slow.yaml
    • Replaced actions/setup-python with astral-sh/setup-uv to install uv.
    • Modified the 'Install Package' step to use uv pip install -e .[test] instead of pip install -e .[test].
    • Modified the 'Test' step to use uv run pytest to run the tests.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


With uv so swift,
The builds now take less time,
A faster workflow.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request switches the GitHub Actions workflows to use uv instead of pip for installing Python dependencies and building packages. This should lead to faster and more efficient workflows. The changes look good overall, but there are a few suggestions for improvement.

Summary of Findings

  • Python Version Consistency: The Python version is updated to 3.11 in the publish workflow, but it's important to ensure consistency across all workflows using Python. Verify that this change doesn't introduce compatibility issues with other parts of the project.
  • uv Usage: The transition to uv seems straightforward, but it's crucial to ensure that all pip commands have been correctly translated to their uv equivalents. Double-check the installation and build steps to avoid any unexpected behavior.

Merge Readiness

The pull request seems to be in good shape for merging, but it's recommended to address the comments provided to ensure consistency and correctness. I am unable to directly approve the pull request, and users should have others review and approve this code before merging.

@fkodom fkodom merged commit a8bebd1 into main Apr 2, 2025
3 checks passed
@fkodom fkodom deleted the spike/uv-install branch April 2, 2025 02:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants