Overhaul Tooling & Setup #5
Conversation
fkodom
commented
Jan 14, 2026
fkodom
commented
- Rework template repo for ruff/ty tooling; first draft of Gemini templatize workflow.
- Update README and templatize script
- Fix one small hiccup with /templatize command
Summary of ChangesHello @fkodom, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the repository's development environment and setup process. It modernizes the tooling by adopting Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request overhauls the project's tooling by replacing black and mypy with ruff and ty, and updates the setup process to use gemini-cli and uv. The changes are a good step towards modernizing the template. However, I've identified a few issues that need addressing. My main concerns are that the uv.lock file is incorrectly added to .gitignore, which will prevent reproducible builds, and that mypy has not been fully removed from the project configuration. I've also included a couple of suggestions to improve the documentation in the README for better clarity and consistency.
| @@ -1,4 +1,5 @@ | |||
| .vscode | |||
| uv.lock | |||
There was a problem hiding this comment.
The uv.lock file should not be ignored. Lock files are intended to be checked into version control to ensure reproducible builds for all developers and in CI environments. According to the uv documentation, uv.lock should be committed.
| test = [ | ||
| "black", | ||
| "mypy", | ||
| "pre-commit", | ||
| "pytest", | ||
| "pytest-cov", | ||
| "ruff", | ||
| "ty", | ||
| ] |
There was a problem hiding this comment.
The mypy package is still listed as a test dependency, which contradicts the PR's goal of replacing mypy with ty. To complete the transition, mypy should be removed from the dependencies. Additionally, the [tool.mypy] configuration section should also be removed from this file for consistency.
test = [
"pre-commit",
"pytest",
"pytest-cov",
"ruff",
"ty",
]
| pip install "{{REPO_NAME}}[test] @ git+ssh://git@github.com/{{REPO_OWNER}}/{{REPO_NAME}}.git" | ||
| ```bash | ||
| # Create and activate a new virtual environment | ||
| uv venv --python 3.12 |
There was a problem hiding this comment.
The installation instructions hardcode Python 3.12, while pyproject.toml specifies requires-python = ">=3.11". To maintain consistency with the project's stated requirements and avoid potential confusion for users of the template, it would be better to use Python 3.11 in this example.
| uv venv --python 3.12 | |
| uv venv --python 3.11 |
| | Tool | Description | Runs on | | ||
| | --- | --- | --- | | ||
| | [black](https://github.com/psf/black) | Code formatter | - `git commit` (through `pre-commit`) <br> - `git push` <br> - pull requests | | ||
| | [ruff](https://github.com/astral-sh/ruff) | Code linter | - `git commit` (through `pre-commit`) <br> - `git push` <br> - pull requests | |
There was a problem hiding this comment.
The description for ruff is listed only as a "Code linter". Since this PR also configures ruff to handle code formatting (replacing black), it would be more accurate to update its description to "Code formatter and linter".
| | [ruff](https://github.com/astral-sh/ruff) | Code linter | - `git commit` (through `pre-commit`) <br> - `git push` <br> - pull requests | | |
| | [ruff](https://github.com/astral-sh/ruff) | Code formatter and linter | - `git commit` (through `pre-commit`) <br> - `git push` <br> - pull requests | |
