Fixing HTTP requests to not include "http://..." in GET request #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…request is just "GET /v1/..." rather than "GET http://api.indextank.com/v1...". This makes the python client work while testing against the REST API in django "runserver" mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The indextank python client is sending its HTTP GET requests with the full URL, instead of just the path & query part. For example, calling list_indexes() would send this HTTP request:
Instead of just:
This patch fixes this by passing empty string for the scheme and netloc parameters to urlunsplit. The current code seems to work with the production indextank server, maybe because nginx is handling the extraneous "http://..." part. But when testing the REST API locally with django "runserver" mode, it was just causing 404s for every request.