Skip to content

feat(fsp): add sub-protocol parameters#1221

Open
dineshpinto wants to merge 3 commits intomainfrom
protocol-parameters
Open

feat(fsp): add sub-protocol parameters#1221
dineshpinto wants to merge 3 commits intomainfrom
protocol-parameters

Conversation

@dineshpinto
Copy link
Contributor

No description provided.

@fassko fassko requested a review from magurh March 6, 2026 08:03
@fassko fassko self-assigned this Mar 6, 2026
| **Precision (step size)** | ≈0.0122% | [`FastUpdatesIncentiveManager.getPrecision`](/ftso/solidity-reference/IFastUpdateIncentiveManager#getprecision) |
| **Range** | 0.0183% | [`FastUpdatesIncentiveManager.getRange`](/ftso/solidity-reference/IFastUpdateIncentiveManager#getrange) |
| **Max range (max increment per block)** | 0.091% (5x) | [`FastUpdatesIncentiveManager.rangeIncreaseLimit`](/ftso/solidity-reference/IFastUpdateIncentiveManager#rangeincreaselimit) |
| **Max increment per second** | 0.054% | - |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove max increment per second since this is a number that depends on block latency

| **Mean updates per block** | 1.5 | [`FastUpdatesIncentiveManager.getExpectedSampleSize`](/ftso/solidity-reference/IFastUpdateIncentiveManager#getexpectedsamplesize) |
| **Precision (step size)** | ≈0.0122% | [`FastUpdatesIncentiveManager.getPrecision`](/ftso/solidity-reference/IFastUpdateIncentiveManager#getprecision) |
| **Range** | 0.0183% | [`FastUpdatesIncentiveManager.getRange`](/ftso/solidity-reference/IFastUpdateIncentiveManager#getrange) |
| **Max range (max increment per block)** | 0.091% (5x) | [`FastUpdatesIncentiveManager.rangeIncreaseLimit`](/ftso/solidity-reference/IFastUpdateIncentiveManager#rangeincreaselimit) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove "(max increment per block)"

| **Update size** | ≈200k (1.33%) | - |
| **Mean updates per block** | 1.5 | [`FastUpdatesIncentiveManager.getExpectedSampleSize`](/ftso/solidity-reference/IFastUpdateIncentiveManager#getexpectedsamplesize) |
| **Precision (step size)** | ≈0.0122% | [`FastUpdatesIncentiveManager.getPrecision`](/ftso/solidity-reference/IFastUpdateIncentiveManager#getprecision) |
| **Range** | 0.0183% | [`FastUpdatesIncentiveManager.getRange`](/ftso/solidity-reference/IFastUpdateIncentiveManager#getrange) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a description for Range in brackets: "(precision * mean updates)"

| **Range** | 0.0183% | [`FastUpdatesIncentiveManager.getRange`](/ftso/solidity-reference/IFastUpdateIncentiveManager#getrange) |
| **Max range (max increment per block)** | 0.091% (5x) | [`FastUpdatesIncentiveManager.rangeIncreaseLimit`](/ftso/solidity-reference/IFastUpdateIncentiveManager#rangeincreaselimit) |
| **Max increment per second** | 0.054% | - |
| **Incentive duration** | 17 blocks (≈29 seconds) | [`FastUpdatesIncentiveManager.getIncentiveDuration`](/ftso/solidity-reference/IFastUpdateIncentiveManager#getincentiveduration) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the "=(29 seconds)" since this depends on block latency


| Metric | Value | Associated functions |
| ------------------------ | ------------- | ---------------------------------------------------------------------------------------------------------------------------------------------- |
| **Update size** | ≈200k (1.33%) | - |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update size for Scaling is not correct. Scaling "updates" technically consist of 3 separate transactions from each data provider: submit1, submit2, and submitSignatures. Each takes around 30k gas (usually from 24k to 31k, depending on the transaction).

Meanwhile, for Block latency updates, i.e. the submitAndPass transactions, the current size is 180k to 260k per transaction.

Regardless, these are not really protocol parameters.

@fassko fassko force-pushed the protocol-parameters branch from 70d4e0d to d155f3e Compare March 9, 2026 09:19
@fassko fassko requested a review from magurh March 9, 2026 09:20
@fassko fassko force-pushed the protocol-parameters branch from d155f3e to 70d4e0d Compare March 9, 2026 09:26
@fassko fassko force-pushed the protocol-parameters branch from 63da612 to 0db4d72 Compare March 9, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants